feat: provision to configure default apps while creating bench #2131
+186
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BreadGenie
reviewed
Sep 5, 2024
Comment on lines
+209
to
+230
| getAppsToInstall() { | ||
| let apps = [ | ||
| this.options.versions | ||
| .find(v => v.name === this.benchVersion) | ||
| .apps.find(app => app.name === 'frappe') | ||
| ].map(app => { | ||
| return { | ||
| name: app.name, | ||
| source: app.source.name | ||
| }; | ||
| }); | ||
|
|
||
| // add default apps | ||
| this.defaultApps.forEach(app => { | ||
| apps.push({ | ||
| name: app.name, | ||
| source: app.source | ||
| }); | ||
| }); | ||
|
|
||
| return apps; | ||
| } |
There was a problem hiding this comment.
We could avoid sending the apps along with source from frontend and instead compute the app and app source map from the backend. Would make the API and code simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings to control and configure default apps
Display default apps
New bench with default apps