Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HybridSaaSPool): create standby sites for all hybrid pool rules #2261

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Nov 6, 2024

  • fix(HybridPool): check for specific app as per record instead of erpnext app
  • fix(HybridPool): dont stop create pooling only one hybrid pool has been replenished

@tanmoysrt tanmoysrt merged commit 29a8a80 into frappe:master Nov 6, 2024
3 of 4 checks passed
@tanmoysrt tanmoysrt deleted the fix_hybrid_saas_pool_issue branch November 6, 2024 06:07
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.91%. Comparing base (45d65fc) to head (925e409).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
press/press/doctype/site/saas_pool.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2261   +/-   ##
=======================================
  Coverage   39.91%   39.91%           
=======================================
  Files         371      371           
  Lines       28093    28093           
=======================================
  Hits        11212    11212           
  Misses      16881    16881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanmoysrt
Copy link
Member Author

The failed tests are not related to this, so merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant