-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[OAuth] Token Retrieve & Authorization Check (#18)
* feat: gin router middleware `RouterAuthorizationCheck` * feat: retrieve access token before consuming the SBI services * fix: remove duplicated code * fix: remove duplicate middleware * chore: update the log message * chore: rm dead code * feat: update interface `NFContext` * Fix: fix linter error * Fix: comment out NFRegister with token * Fix: update openapi --------- Co-authored-by: CTFang@WireLab <[email protected]>
- Loading branch information
Showing
8 changed files
with
168 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "net/http" | ||
|
|
||
| "github.com/gin-gonic/gin" | ||
|
|
||
| nssf_context "github.com/free5gc/nssf/internal/context" | ||
| "github.com/free5gc/nssf/internal/logger" | ||
| ) | ||
|
|
||
| type RouterAuthorizationCheck struct { | ||
| serviceName string | ||
| } | ||
|
|
||
| func NewRouterAuthorizationCheck(serviceName string) *RouterAuthorizationCheck { | ||
| return &RouterAuthorizationCheck{ | ||
| serviceName: serviceName, | ||
| } | ||
| } | ||
|
|
||
| func (rac *RouterAuthorizationCheck) Check(c *gin.Context, nssfContext nssf_context.NFContext) { | ||
| token := c.Request.Header.Get("Authorization") | ||
| err := nssfContext.AuthorizationCheck(token, rac.serviceName) | ||
| if err != nil { | ||
| logger.UtilLog.Debugf("RouterAuthorizationCheck: Check Unauthorized: %s", err.Error()) | ||
| c.JSON(http.StatusUnauthorized, gin.H{"error": err.Error()}) | ||
| c.Abort() | ||
| return | ||
| } | ||
|
|
||
| logger.UtilLog.Debugf("RouterAuthorizationCheck: Check Authorized") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/gin-gonic/gin" | ||
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| const ( | ||
| Valid = "valid" | ||
| Invalid = "invalid" | ||
| ) | ||
|
|
||
| type mockNSSFContext struct{} | ||
|
|
||
| func newMockNSSFContext() *mockNSSFContext { | ||
| return &mockNSSFContext{} | ||
| } | ||
|
|
||
| func (m *mockNSSFContext) AuthorizationCheck(token string, serviceName string) error { | ||
| if token == Valid { | ||
| return nil | ||
| } | ||
|
|
||
| return errors.New("invalid token") | ||
| } | ||
|
|
||
| func TestRouterAuthorizationCheck_Check(t *testing.T) { | ||
| // Mock gin.Context | ||
| w := httptest.NewRecorder() | ||
| c, _ := gin.CreateTestContext(w) | ||
|
|
||
| var err error | ||
| c.Request, err = http.NewRequest("GET", "/", nil) | ||
| if err != nil { | ||
| t.Errorf("error on http request: %+v", err) | ||
| } | ||
|
|
||
| type Args struct { | ||
| token string | ||
| } | ||
| type Want struct { | ||
| statusCode int | ||
| } | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| args Args | ||
| want Want | ||
| }{ | ||
| { | ||
| name: "Valid Token", | ||
| args: Args{ | ||
| token: Valid, | ||
| }, | ||
| want: Want{ | ||
| statusCode: http.StatusOK, | ||
| }, | ||
| }, | ||
| { | ||
| name: "Invalid Token", | ||
| args: Args{ | ||
| token: Invalid, | ||
| }, | ||
| want: Want{ | ||
| statusCode: http.StatusUnauthorized, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| w = httptest.NewRecorder() | ||
| c, _ = gin.CreateTestContext(w) | ||
| c.Request, err = http.NewRequest("GET", "/", nil) | ||
| if err != nil { | ||
| t.Errorf("error on http request: %+v", err) | ||
| } | ||
| c.Request.Header.Set("Authorization", tt.args.token) | ||
|
|
||
| rac := NewRouterAuthorizationCheck("testService") | ||
| rac.Check(c, newMockNSSFContext()) | ||
| if w.Code != tt.want.statusCode { | ||
| t.Errorf("StatusCode should be %d, but got %d", tt.want.statusCode, w.Code) | ||
| } | ||
| }) | ||
| } | ||
| } |