Update atomic.h, 64 bit compare exchange on ARM 32 #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone.
Forgive me if I am not following the rules. This is a quick fix, and I like to stay private.
Assembly code pertaining to ARM 32bit processors acting on 64bit wide data in what amounts to a compare and exchange operation has an apparent bug where the current value in memory that is returned to the caller is the same suspected current value that was passed by the caller even when the exchange fails.
Please be warned that this apparent bug was caught by code analysis, not testing.