newsyslog: Add tests for rotating files based on size #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Esham <[email protected]>
Previously, the run_newsyslog function always called newsyslog with the "-F" flag, which tells it to trim log files even if the criteria haven't been met. This was fine for the existing tests, but it meant that it would be impossible to test the trimming process itself. Now, the -F flag is used within individual tests as needed. Signed-off-by: Benjamin Esham <[email protected]>
Signed-off-by: Benjamin Esham <[email protected]>
asomers
suggested changes
May 28, 2025
|
@asomers I’m happy to revise this, but I’m not very familiar with FreeBSD’s testing infrastructure. Are you requesting that I rewrite the tests in C specifically? I would feel a lot more comfortable rewriting them as an ATF shell script (like usr.sbin/sysrc/tests/sysrc_test.sh, just to pick a concrete example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for newsyslog(8) did not previously test size-based rotation, e.g., “rotate
foo.logonce it becomes larger than 8 KB.” This pull request adds a few tests for this functionality.