Update tramp.S #1705
Open
Update tramp.S #1705
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking the time to contribute to FreeBSD!
|
|
The change itself looks good. However, the commit message should be changed to "kboot: Fix typo in comment" which is more descriptive and follows the 'Subject line' convention the project has. There's really no need for the typical 'body' of the commit message, however, since it won't add any details or nuance that aren't there in the 'subject'. This FreeBSD Journal article has more details https://freebsdfoundation.org/wp-content/uploads/2020/11/Writing-Commit-Messages.pdf |
bsdimp
added
the
changes-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.