-
Notifications
You must be signed in to change notification settings - Fork 193
Small fixes for issues we encountered during the 0.8.0 release #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As far as I'm aware qube creation is solely done by the |
update: never mind. I thought I was looking at the INSTALL instructions and not the BUILD (a.k.a. dev-facing ones). There's of course no need to build guard-rails for those. But this reminded me that there may be challenges getting dynamically downloaded OCR languages (#488) to work on Qubes. I'll write on the respective ticket (DONE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, except some of the comments I added, but they're mainly about readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I've added a small nitpick, do what you want with it :-)
b63c1f4
to
64389c3
Compare
Increase the size of the `dz` qube in our build instructions. We increase it from 2GiB (default), to 5GiB (suggested), in order to cater for some extra space that our build instructions need (e.g., the download of the Tesseract data).
Implement the following steps from the QA docs: 1. Check if the latest Python version that we support is installed. For example, we currently support Python 3.12, so we add code to check that the latest Python 3.12.x version is installed. 2. Download the Tesseract data using our script, both on Windows and Linux.
64389c3
to
ce5aca4
Compare
This PR tackles the following minor issues:
dz
qube larger, now that we ask users to download Tesseract data. Initially the/home
disk size was 2GiB, and with this change, we bump it to 5GiB.