-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes for issues we encountered during the 0.8.0 release #996
base: main
Are you sure you want to change the base?
Conversation
Increase the size of the `dz` qube in our build instructions. We increase it from 2GiB (default), to 5GiB (suggested), in order to cater for some extra space that our build instructions need (e.g., the download of the Tesseract data).
Implement the following steps from the QA docs: 1. Check if the latest Python version that we support is installed. For example, we currently support Python 3.12, so we add code to check that the latest Python 3.12.x version is installed. 2. Download the Tesseract data using our script, both on Windows and Linux.
As far as I'm aware qube creation is solely done by the |
update: never mind. I thought I was looking at the INSTALL instructions and not the BUILD (a.k.a. dev-facing ones). There's of course no need to build guard-rails for those. But this reminded me that there may be challenges getting dynamically downloaded OCR languages (#488) to work on Qubes. I'll write on the respective ticket (DONE). |
BUILD.md
Outdated
@@ -260,11 +260,16 @@ The following instructions require typing commands in a terminal in dom0. | |||
|
|||
``` | |||
qvm-create --class AppVM --label red --template fedora-40-dz dz | |||
qvm-volume resize dz:private $(numfmt --from=auto 5Gi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well make larger. Maybe 20GB? Because Qubes uses LVM thin-provisioning this doesn't actually occupy more space and may have another "guide update" should Dangerzone ever need more space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, makes sense. Just did so in d286aea, and added an extended explanation.
Because Qubes uses LVM thin-provisioning this doesn't actually occupy more space
Fun fact, actually this is a bit more nuanced. If you create and delete multiple files, the net size difference may be 0 on the mounted filesystem, but the underlying thin LV may grow to the maximum size. Users would need to fstrim
their mounted filesystem to reclaim that space from the thin LV, but that's not done by default in Qubes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know. That probably explains why my dangerzone development qube would balloon in size even though when I measure the disk within the qube, it would not be that big.
This PR tackles the following minor issues:
dz
qube larger, now that we ask users to download Tesseract data. Initially the/home
disk size was 2GiB, and with this change, we bump it to 5GiB.