Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for issues we encountered during the 0.8.0 release #996

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Nov 11, 2024

This PR tackles the following minor issues:

  1. Make the dz qube larger, now that we ask users to download Tesseract data. Initially the /home disk size was 2GiB, and with this change, we bump it to 5GiB.
  2. Remove a reference to a second container from our README.
  3. Update our QA script to implement two more steps from our instructions.

Increase the size of the `dz` qube in our build instructions. We
increase it from 2GiB (default), to 5GiB (suggested), in order to cater
for some extra space that our build instructions need (e.g., the
download of the Tesseract data).
Implement the following steps from the QA docs:

1. Check if the latest Python version that we support is installed. For
   example, we currently support Python 3.12, so we add code to check
   that the latest Python 3.12.x version is installed.
2. Download the Tesseract data using our script, both on Windows and
   Linux.
@apyrgio
Copy link
Contributor Author

apyrgio commented Nov 11, 2024

@deeplow: One quick question about 8f8252e. I haven't found a way to create an app qube and define the disk size at the same time, hence the separate command. Do you know of a more canonical method?

@deeplow
Copy link
Contributor

deeplow commented Nov 11, 2024

As far as I'm aware qube creation is solely done by the qvm-create and qvm-clone commands and they don't allow for control of volume creation other than where it will be created. So it has to be a separate command. Also, I don't think it being exactly 5GiB is strictly necessary, but it does not harm (other than a longer commmand).

@deeplow
Copy link
Contributor

deeplow commented Nov 11, 2024

An additional potential improvement (which I haven't checked if it exist or not) would be to check if there is enought space available before downloading tesseract data. This could be helpful also on non-Qubes systems.

It will be really nice when this turns into a multiVM application (kind of like SecureDrop) where updates also happen at the Qubes-level, so that the user doesn't have to keep reconfiguring the system. But that's a longer effort, especially because the installation and update story is not very polished yet.

update: never mind. I thought I was looking at the INSTALL instructions and not the BUILD (a.k.a. dev-facing ones). There's of course no need to build guard-rails for those. But this reminded me that there may be challenges getting dynamically downloaded OCR languages (#488) to work on Qubes. I'll write on the respective ticket (DONE).

BUILD.md Outdated
@@ -260,11 +260,16 @@ The following instructions require typing commands in a terminal in dom0.

```
qvm-create --class AppVM --label red --template fedora-40-dz dz
qvm-volume resize dz:private $(numfmt --from=auto 5Gi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well make larger. Maybe 20GB? Because Qubes uses LVM thin-provisioning this doesn't actually occupy more space and may have another "guide update" should Dangerzone ever need more space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense. Just did so in d286aea, and added an extended explanation.

Because Qubes uses LVM thin-provisioning this doesn't actually occupy more space

Fun fact, actually this is a bit more nuanced. If you create and delete multiple files, the net size difference may be 0 on the mounted filesystem, but the underlying thin LV may grow to the maximum size. Users would need to fstrim their mounted filesystem to reclaim that space from the thin LV, but that's not done by default in Qubes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. That probably explains why my dangerzone development qube would balloon in size even though when I measure the disk within the qube, it would not be that big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants