app: Open files in sd-viewer dispVM #2841
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ability to open downloaded files in the sd-viewer disposable VM. Users can click on completed file items in the conversation view, which triggers the backend to open the file using qvm-open-in-vm.
Key changes:
- Added click handler to file buttons that calls the new
openFileAPI - Implemented IPC handler that validates file existence and spawns
qvm-open-in-vmprocess - Added the
openFilemethod to the Electron API bridge
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/renderer/views/Inbox/MainContent/Conversation/Item/File.tsx | Added onClick handler to completed file buttons and removed TODO comment |
| app/src/renderer/test-component-setup.tsx | Added mock for openFile API in test setup |
| app/src/preload/index.ts | Exposed openFile IPC method through the Electron API bridge |
| app/src/main/index.ts | Implemented IPC handler that validates item/file existence and launches qvm-open-in-vm |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The frontend asks the backend to open a specific UUID, and the backend looks it up and passes the filename to `qvm-open-in-vm`. This unconditionally opens files in the sd-viewer dispVM, there is no exception for dev environments or otherwise (just like the client). Fixes #2838.
legoktm
force-pushed
the
app-open-viewer
branch
from
2572acc to
174deae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend asks the backend to open a specific UUID, and the backend looks it up and passes the filename to
qvm-open-in-vm.This unconditionally opens files in the sd-viewer dispVM, there is no exception for dev environments or otherwise (just like the client).
Fixes #2838.
Fixes #
Test plan
Checklist
This change accounts for:
main)