Split generate and sign steps; add more CI checks #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
split-generate-sign
branch
from
d7b267e
to
d5cb449
Compare
|
Rebased this on top of #205, which I used this for. So it works :) |
zenmonkeykstop
requested changes
Sep 30, 2024
One of the biggest frustrations I have with this process is that the generation and signing steps are combined. I really want to generate everything, review it, and then move ahead with signing. This splits the two steps and inlines them into the Makefile as separate `make generate` and `make sign`. Also change the default goal to `help`, which is what all of our other Makefiles do. This necessitates checking in the default.rulesets file that's used as the input for signing.
And update the reference that Tor Browser now correctly checks the -2021 variant.
legoktm
force-pushed
the
split-generate-sign
branch
from
a4a39d4
to
c94b549
Compare
|
Done! |
zenmonkeykstop
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
One of the biggest frustrations I have with this process is that the
generation and signing steps are combined. I really want to generate
everything, review it, and then move ahead with signing.
This splits the two steps and inlines them into the Makefile as separate
make generateandmake sign. Also change the default goal tohelp,which is what all of our other Makefiles do.
This necessitates checking in the default.rulesets file that's used as
the input for signing.
As requested in #21, this verifies:
a reimplementation of the
upstream/merge-rulesets.pyscript, but wouldstop a zero-length ruleset from being deployed)
Fixes #21.
Review Checklist