Improve GitHub actions behavior on "unkown" OpenQA status #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the tests failed due to "timeout_exceeded", but this was not was an unkown result [1]. Adding more exit status from OpenQA should cover a few more scenarios. But according to the OpenQA docs, this is an incomplete list [2]. [1]: https://github.com/freedomofpress/securedrop-workstation/actions/runs/19579932625/job/56075156340?pr=1373#step:7:90 [2]: https://open.qa/docs/#_jobs
A GitHub-OpenQA job failed with "unknown status" [1] and yet, it had marked the respective OpenQA tests as green/passing. This was because in the "unkown status" condition it was not explicitly setting a failing check for the respective OpenQA job on GitHub. [1]: https://github.com/freedomofpress/securedrop-workstation/actions/runs/19579932625/job/56075156340?pr=1373#step:7:90
deeplow
added
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Not sure how to go about simulating all of these scenarios. In my mind, this can be just a visual review and if it leads to problems we revisit it. It seems straightforward enough and it was directly copied from the docs.