Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Interface: Flow Inversion #6438

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft

Source Interface: Flow Inversion #6438

wants to merge 19 commits into from

Commits on Jun 20, 2022

  1. Minimum viable flow inversion, backend implementation 

    Towards #6211

Up until now, SecureDrop had an implicit "sign up" flow, in which
sources were assigned a codename/passphrase before they were able to
submit any messages/documents.

This created a couple of technical pitfalls with regards to session
management and (potentially) usability issues as well (user research
pending). As sources were asked to write down their
codenames/passphrases before they were able to do for what
they came to the instance for, we made sure to remind them of their
codename repeatedly.

Flow inversion seeks to simplify both the backend implementation as well
as the source interface's user experience.
    @eaon @zenmonkeykstop
    eaon authored and zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    494e767 View commit details
    Browse the repository at this point in the history

  2. Support session expiry on screens where login isn't mandatory anymore 

    Plus some cleanup
    @eaon @zenmonkeykstop
    eaon authored and zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    f953d09 View commit details
    Browse the repository at this point in the history

  3. Show codename by default now 

    Needs discussion: is there a reason to keep the show codename button
around? If so, we want to track it's state for the session so as to not
confuse sources on page refreshes.
    @eaon @zenmonkeykstop
    eaon authored and zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    66f8fad View commit details
    Browse the repository at this point in the history

  4. Inverted Flow WIP 

    More optimisation wrt message validation vs. when to actually create a new
source account, and start replacing codename with passphrase terminology
    @eaon @zenmonkeykstop
    eaon authored and zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    ea2f85f View commit details
    Browse the repository at this point in the history

  5. Inverted functional test fixes

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    1e2c68a View commit details
    Browse the repository at this point in the history

  6. fixes for tests/functional/test_admin_interface.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    add2e66 View commit details
    Browse the repository at this point in the history

  7. fixes for tests/test_source.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    016ab3b View commit details
    Browse the repository at this point in the history

  8. fix: initial submissions should get a notification mentioning replies

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    3eb80e1 View commit details
    Browse the repository at this point in the history

  9. Fixed validation for overly-long messages, more tests/test_source.py … 

    …fixes
    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    3694951 View commit details
    Browse the repository at this point in the history

  10. fixed tests in tests/test_source.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    a62d9a3 View commit details
    Browse the repository at this point in the history

  11. fixed tests in tests/integration.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    8c48425 View commit details
    Browse the repository at this point in the history

  12. fixed tests in functional/test_submit_and_retrieve_file.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    1b5bb3e View commit details
    Browse the repository at this point in the history

  13. fixed tests in functional/test_source.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    de4d53e View commit details
    Browse the repository at this point in the history

  14. fixed tests in functional/test_source_designation_collision.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    d00431a View commit details
    Browse the repository at this point in the history

  15. fixed tests in functional/test_journalist.py

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    b64a158 View commit details
    Browse the repository at this point in the history

  16. fixed tests in pageslayout/ tests

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    dadeeac View commit details
    Browse the repository at this point in the history

  17. Replaced "codename" with "passphrase" 

    - updated interface strings
- for consistency, updated CSS names as well
- updated session key name
    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    f60fe90 View commit details
    Browse the repository at this point in the history

  18. updated 'codename' to 'passphrase' in tests

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    8440b53 View commit details
    Browse the repository at this point in the history

  19. post-rebase test fixes

    @zenmonkeykstop
    zenmonkeykstop committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    8fee868 View commit details
    Browse the repository at this point in the history