Support podman in make dev-tor

[legoktm]

Status

Ready for review

Description of Changes

Unfortunately podman volume and docker volume are not identical, podman will (sensibly) error if you try to create a volume that already exists unless you pass --ignore, which docker doesn't support.

So we conditionally add the needed flag depending on which tool we're using.

Testing

• Visual review
• Run make dev-tor twice under docker, make sure it works
• Run make dev-tor twice under podman, make sure it works (I've done this laready)

Deployment

Any special considerations for deployment? n/a, dev only

Checklist

• These changes do not require documentation

[deeplow]

Thanks for finding this, at the time when I added the onion persistence I guess I did not realize podman was also supported. The solution didn't work for me so I proposed an alternative.

There's also another thing that needs to be provider-agnostic: the make clean.

[legoktm]

Thanks for the suggestion, now applied and fixed make clean as well.

[deeplow]

Thanks for the fixes. I was reviewing this but got blocked by #7174.

[deeplow]

Thanks for the fixes. I was reviewing this but got blocked by #7174.

The above got resolved. However, I am having further challenges with podman, which seems to be beyond just make dev-tor, since it also fails with make dev.

Here's some truncated part of the output or USE_PODMAN=1 make dev

[...]

Exposed services will be available on localhost at
Source interface: http://127.0.0.1:8080
Journalist interface: http://127.0.0.1:8081
************************************************************
sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?
sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?
Unable to replace /dev/random
Starting to build Rust code
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s
Copying libredwood.so into package

[...]
Successfully installed redwood-0.1.0
WARNING: You are using pip version 21.1.1; however, version 24.1.2 is available.
You should consider upgrading via the '/opt/venvs/securedrop-app-code/bin/python3 -m pip install --upgrade pip' command.
███ Generating securedrop/config.py...

sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?
make: *** [Makefile:250: dev] Error 1

Do you know what could be going on? I was on a disposable debian-12 VM on Qubes. Then I installed make and podman and ran USE_PODMAN=1 make dev.

[deeplow]

LGTM. Approving based on visual inspection alone since I can't seem to run this. This a minor dev-facing (non-default) option, so I'd say this can be fine.

However, it would be nice if someone else could test:

• Run make dev-tor twice under docker, make sure it works
• Run make dev-tor twice under podman, make sure it works (I've done this laready)