Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in staging test_app_code_venv caused by reformatting #7246

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Oct 11, 2024

Status

Ready for review

Description of Changes

I messed up manually breaking the long line in 7ad8828. This version should be functionally identical to how it was previously.

Fixes #7243.

Testing

How should the reviewer test this PR?

  • CI passes

Deployment

Any special considerations for deployment? n/a

Checklist

I messed up manually breaking the long line in 7ad8828. This version
should be functionally identical to how it was previously.

Fixes #7243.
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting for the record that the review failure here (on my part!) involved a diff affecting (indeed, in) tests run only in the staging suite, which didn't run on #7233. Thanks for the quick fix, @legoktm.

@cfm cfm added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 6f04908 Oct 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

staging test_app_code_venv test failing
2 participants