-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6405 Fix wcag annotations #7314
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,19 +2,19 @@ | |
<a href="#close" class="external" aria-label="{{ gettext('Close') }}"></a> | ||
<dialog open id="delete-confirm-menu-dialog" aria-labelledby="confirm-heading"> | ||
<h2 id="confirm-heading" class="paragraph-spacing"> | ||
{{ gettext('When the account for a source is deleted:') }} | ||
{{ gettext('When the account for a <abr title="user">source</abr>is deleted:') }} | ||
</h2> | ||
<ul> | ||
<li>{{ gettext('The source will no longer be able to log in with their codename.') }}</li> | ||
<li>{{ gettext('The <abr title="user">source</abr> will no longer be able to log in with their <abbr title="user name">codename</abbr>.') }}</li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's unclear that terms like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason why I thought it would be nice to have was because its a bit unclear as a new user what a codename is as its a term used specifically by the app. Let me know if I need to update @zenmonkeykstop |
||
<li>{{ gettext('You will not be able to send them replies.') }}</li> | ||
<li>{{ gettext('All files and messages from that source will also be destroyed.') }}</li> | ||
<li>{{ gettext('All files and messages from that <abr title="user">source</abr> will also be destroyed.') }}</li> | ||
</ul> | ||
<p class="modal-danger-text">{{ gettext('Are you sure this is what you want?') }}</p> | ||
<div class="btn-row"> | ||
<a href="#close" id="cancel-collections-deletions" title="{{ gettext('Cancel') }}" | ||
class="btn cancel small">{{ gettext('Cancel') }}</a> | ||
<button type="submit" id="delete-collections-confirm" name="action" value="delete" | ||
class="btn small danger">{{ gettext('Yes, Delete Selected Source Accounts') }}</button> | ||
class="btn small danger">{{ gettext('Yes, Delete Selected <abr title="user">Source</abr> Accounts') }}</button> | ||
</div> | ||
</dialog> | ||
</div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,7 @@ <h2 id="users-heading" class="visually-hidden">Users</h2> | |
|
||
<a href="{{ url_for('admin.manage_config') }}" class="btn icon icon-edit section-spacing-inline" | ||
id="update-instance-config" aria-label="{{ gettext('Update instance configuration') }}"> | ||
{{ gettext('INSTANCE CONFIG') }} | ||
{{ gettext('INSTANCE CONFIGURATION') }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably out of scope for WCAG annotations and will require translation changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay, sounds good - will remove for now |
||
</a> | ||
|
||
{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the tag should be
<abbr title="...">
not<abr title="...">
- unsure if both are valid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked it up and both are valid - https://www.w3schools.com/tags/tag_abbr.asp