Skip to content

Fix division by zero in delete-disconnected-fs-submissions #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heathdutton wants to merge 2 commits into
base: develop
Choose a base branch
from
+1 −1
Open

Fix division by zero in delete-disconnected-fs-submissions #7746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e3beb
Fix division by zero in delete-disconnected-fs-submissions
heathdutton Dec 31, 2025
baea2c1
Merge branch 'freedomofpress:develop' into 7201-fix-submissions-divis…
heathdutton Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion securedrop/management/submissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def delete_disconnected_fs_submissions(args: argparse.Namespace) -> None:
remove = input(f"Enter 'y' to delete {f}: ") == "y"
if remove:
filesize = os.stat(f).st_size
if i > 1:
if i > 1 and rate > 0:
eta = filesize / rate
eta_msg = f" (ETA to remove {filesize:d} bytes: {eta:.0f}s )"
print(f"Securely removing file {i}/{filecount} {f}{eta_msg}...")
Expand Down