Return HTTP 404 instead of 500 for missing files in serve_file_with_etag #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

heathdutton wants to merge 2 commits into freedomofpress:develop from heathdutton:fix/7202-serve-file-404-response

heathdutton commented Dec 31, 2025

Fixes #7202

Test plan

Create a source and submit a message/file
Delete the source's directory from /var/lib/securedrop/store
Attempt to download the submission via the API
Verify HTTP 404 is returned instead of 500

Checklist

This change accounts for:

any required additional documentation
any necessary AppArmor changes (added or removed application files)
any impact on new SecureDrop installs and upgrades
our dependency update policy


          Return HTTP 404 instead of 500 for missing files in serve_file_with_etag

8cfb047

heathdutton requested a review from a team as a code owner

December 31, 2025 18:05


          Merge branch 'freedomofpress:develop' into fix/7202-serve-file-404-re…

fcce4f5

…sponse

zenmonkeykstop added this to SecureDrop

zenmonkeykstop moved this to Next sprint candidates in SecureDrop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet