Import only newly added sites from CSV #114
Conversation
There was a problem hiding this comment.
First of all - sorry for the delay on reviewing this, @eloquence! This is a good start.
My main thought in reviewing this is that it only handles additions to the CSV file. If you were to remove a site from the CSV file and run loadsites, it would not be removed from the database. Therefore, this is not a complete resolution for #110, but it is a step in the right direction.
The question is: is it worth merging on its own as a partial solution? I think the answer is yes, because we've only had cause to add sites to Secure the News so far, so I don't think we need to block progress on supporting the removal use case.
Before using this to update sites on the production server, we should export the current list of tracked sites from the production server and update the news_sites.csv file stored in the Git repo. I can handle that in a separate PR.
|
*nod* I figured this would be a good place to start changing the workflow. Re: export, would you like me to make a dumpsites.py equivalent for loadsites? |
|
Sorry for the holdup here, @eloquence. Trying to get this in shortly so we can update the site, since we've got a few dangling PRs here. |
|
Introduced conflicts via merge of #123. @eloquence if you can rebase on top of latest master, we're good to merge—otherwise I'll pull your commit into a separate feature branch and perform the rebase in a superseding PR. |
This should help with freedomofpress#110, will need more work if we want to manage additional site metadata such as tags this way.
|
done :) |
This should help with #110, will need more work if we want to manage
additional site metadata such as tags this way.