freegs-NK #66
Open
freegs-NK #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hough no limited plasma features currently)
|
What needs to be done in order to merge the NK solver? Are there some other reasons why the code has not been merged? |
Collaborator
Author
|
Hi @df5276 Sorry this has been held up so long. It would be good if someone else could check that this doesn't break any existing workflows. @chrismarsden7 ? |
Contributor
Hi @bendudson , I'll take a look at this - apologies that this has slipped passed me. I'll give this a test over the weekend and see how it fares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Newton-Krylov non-linear solver, located in freegs/newtonk.py. This is used for forward GS problems (i.e. when coil currents are fixed and 'solve' is called with 'constrain=None'). Solution of inverse problems uses Picard iterations, unchanged. @georgeholt1 @aagnello @nicamo