Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get instead of head in hidden API because of issues with NYSD court #1300

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

Lezh1k
Copy link
Contributor

@Lezh1k Lezh1k commented Jan 13, 2025

Resolves this rare issue: #1268

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@ERosendo
Copy link
Contributor

ERosendo commented Jan 16, 2025

@Lezh1k Thanks for the PR.

Did you test this update using documents from the following courts:

  • Judicial Panel on Multidistrict Litigation(jpml)
  • Eastern district of Virginia (vaed)?

I've been testing your code with various courts, and I've encountered issues using GET specifically for JPML and VAED documents. When using the HEAD method, both courts work as expected.

Here are the details of the documents I'm using from these courts:

court_id case_id document_number attachment_number
jpml 1706770 1 16
vaed 566951 1 1

@Lezh1k
Copy link
Contributor Author

Lezh1k commented Jan 16, 2025

@ERosendo

No, I tested it with nysd, ded, scd, miwd and ilnd courts.
But did not test with all courts, of course. I'll add a test then and try to fix the cases you gave me.
Thank you.

@ERosendo
Copy link
Contributor

Here's a table summarizing all documents successfully processed using this new code:

court_id case_id document_number attachment_number
cand 392923 296
casd 740377 4
ded 79852 48
flnd 522710 19
gand 338451 4
hid 171407 19
insd 216381 27
ksd 154075 28
kyed 85350 248
med 64568 113
mdd 556480 468 1
mssd 127001 4
mowd 181314 2 1
nhd 64790 5
ncmd 97963 24
ohnd 312386 5
okwd 129789 4
pamd 144274 45
tnwd 103652 21
txed 227008 203
uscfc 51348 38
alnd 179302 431
gasd 107296 1 3
mad 279218 5
nysd 632608 48
oknd 67495 120
paed 622413 21
vtd 35143 145
waed 110285 6
dcd 269934 50
cod 240358 4
flmd 436580 3
sdd 73752 90
tned 110677 81
txsd 1988365 1
flsd 677533 5
cit 16757 50
almd 83221 295
alsd 74642 13
akd 75448 1 12
azd 1421366 10
ared 145932 15
cacd 928365 18
gamd 132032 29
idd 36853 95
ilcd 86873 139
ilnd 462333 16
ilsd 85178 125
innd 121141 8
iand 67394 15
iasd 89270 9
kywd 137499 12
laed 265913 13
lamd 60743 160
lawd 209283 12
mied 382132 1
miwd 112879 40
mnd 216946 15
msnd 48663 101
mtd 79558 7
ned 104873 6
nvd 172446 13 7
njd 561381 1
nmd 492538 26
nynd 146457 3
nywd 154018 1 1
nced 212533 10
ncwd 116035 64
ndd 66001 21
ohsd 297461 7
oked 36249 17
ord 171008 4
pawd 315661 54 2
rid 58749 6
scd 298591 5
tnmd 102648 6
txnd 397768 36
txwd 1172802329 4
utd 145042 54
vawd 127787 162
wawd 341050 12
wvnd 60521 19
wvsd 237440 22
wied 89455 65
wyd 59492 144
gud 11362 209
nmid 6299 45
prd 172106 1146
vid 39846 50
arwd 73085 6
ctd 162585 38

@Lezh1k
Copy link
Contributor Author

Lezh1k commented Jan 20, 2025

@ERosendo I'm sorry, I did not get what's wrong with vaed 566951 .
By number 1:25-cv-00080 and court vaed I receive this:

{
    "data": {
        "docket_number": "1:25-cv-00080",
        "pacer_case_id": "566951"
    }
}

I mean at least request to PossibleCaseNumberAPI works fine. (This is output from my wrapper) .

@ERosendo
Copy link
Contributor

ERosendo commented Jan 20, 2025

@Lezh1k Thanks for revisiting this. I re-ran the script to verify this PR functionality, and this time all 94 courts were processed successfully. I'm uncertain why JPML and VAED encountered issues during my initial check, but the problem appears to be resolved now.

@ERosendo ERosendo merged commit 2839316 into freelawproject:main Jan 20, 2025
7 checks passed
@Lezh1k
Copy link
Contributor Author

Lezh1k commented Jan 21, 2025

@ERosendo Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants