-
-
Notifications
You must be signed in to change notification settings - Fork 128
feat(OpinionSite): return "lower_court_id" field #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Solves #1432 This new field will go into "Docket.appeal_from_id" Also, make `tex` scraper return "lower_court_id"
abe7443
to
716ec9d
Compare
I think we need to fix the Texas scraper with respect to IDs before we move this forward, perhaps we should make this a draft |
@@ -162,16 +163,21 @@ def parse_lower_court_info(title: str) -> tuple[str, str]: | |||
if match := re.search(texapp_regex, title): | |||
lower_court = match.group("lower_court") | |||
lower_court_number = title[match.end() :].split(",")[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstrings on this function are not correct.
also Instead of not returning BODA id I created one in courts-db txboda
@grossir I find this
to be problematic. Can we return it to just return the lower court number and extract out the remaining data from extract from text.
I think I like the way the courts names are written here - they match and look much nicer to me. |
I was checking the PDFs and I would keep the data from the HTML source, because it has:
About the formatting being prettier or more standard in the PDF, when we implement the frontend we will just use the "appeal_from_id", which links to a |
@grossir I think the HTML is providing a non standard name for the court and I much prefer the format from the PDF. let me take a look at a bigger sample |
Solves #1432
This new field will go into "Docket.appeal_from_id"
Also, make
tex
scraper return "lower_court_id"