fix(tex): Added error handling for empty order list #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flooie
requested changes
Jan 13, 2026
Contributor
flooie
left a comment
flooie
left a comment
There was a problem hiding this comment.
this doesnt seem like the right fix to me.
@Luis-manzur This fix just papers over the fact that in January they wont have any links to propagate over. Here you simply return the original url which wont have any opinions and then you filter things without a date which obviously is none.
Instead, we should bail if there are no links in January instead of adding this extra clutter
…der-list-in-tex # Conflicts: # CHANGES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1738