ENH: Add cibuildwheel and automated PyPI release #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Oct 6, 2025
| @@ -1,2 +1,7 @@ | |||
| [build-system] | |||
| requires = ['setuptools', 'wheel', 'Cython>=3.0', 'numpy'] | |||
| requires = ['setuptools', 'wheel', 'Cython>=3.0', 'numpy>=2'] | |||
Author
There was a problem hiding this comment.
I'd suggest updating the python min to 3.10 at the same time (3.9 is EOL Oct 30), happy to push that. Building with NumPy >= 2 is useful to ensure that code is both NumPy 1.x and 2.x compatible. But I can roll this back if needed and just make sure that cibuildwheel installs a NumPy >= 2, though it does complicate the code a bit.
Open
Author
|
I also just saw #54... after this PR is merged, if someone bumps the version in |
Author
|
Modified to use EDIT: Appears to have worked: https://github.com/larsoner/surfa/actions/runs/19711633336/job/56473558969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
Closes #17
Seems to be working:
https://github.com/larsoner/surfa/actions/runs/18286055605
Also enables PyPI automated publishing when a tagged release is cut