V0.1beta #1
V0.1beta #1
Conversation
…them, shane: need to fix swig.i so the stuff I changed to by hand works when generated
…e, time to test, and write some samples
…so I can un-comment out stuff in thie file
…s no AssemblyLoadContext.Default
… load them via API
| /Loader/.vs/Loader/v16/Server/sqlite3 | ||
| /.vs/Managed/v16 | ||
| /Loader/.vs/Loader/DesignTimeBuild/.dtbcache | ||
| *.dtbcache |
There was a problem hiding this comment.
Reduce all this to just:
.vs
|
Remove intermediate binary file @ .vs/Managed/DesignTimeBuild/.dtbcache.v2 |
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
|
|
There was a problem hiding this comment.
Is the ASP reference necessary or left over from testing?
| <PropertyGroup> | ||
| <ShowAllFiles>true</ShowAllFiles> | ||
| </PropertyGroup> | ||
| </Project> |
There was a problem hiding this comment.
Remove this file, .user files should be local only.
| { | ||
| public interface IPluginDispatcher | ||
| { | ||
| bool Onload(); |
There was a problem hiding this comment.
Can we change this to: OnLoad?
|
|
||
| string DispatchXMLCallback(string section, string tag, string key, string value, Event evt); | ||
|
|
||
| IEnumerable<string> GetApiNames(); |
There was a problem hiding this comment.
Change to GetAPINames for consistency.
| @@ -2069,7 +2069,7 @@ namespace FreeSWITCH { | |||
| public class SWIGTYPE_p_switch_event_t { | |||
| private global::System.Runtime.InteropServices.HandleRef swigCPtr; | |||
|
|
|||
| internal SWIGTYPE_p_switch_event_t(global::System.IntPtr cPtr, bool futureUse) { | |||
| public SWIGTYPE_p_switch_event_t(global::System.IntPtr cPtr, bool futureUse) { | |||
| swigCPtr = new global::System.Runtime.InteropServices.HandleRef(this, cPtr); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
All the changes in this file appear to be made in this file, as this is generated by swig, we need to alter the swig.i to make these public upon regeneration.
I'm not exactly sure the correct format for the swig.i because this is for constructors, will have to look into this.
An example exists in the swig.i for a normal method, it should look a little something like this, with the obvious changes:
%csmethodmodifiers CoreSession::originate "protected";
| @@ -33,6 +33,8 @@ public struct NativeCallbacks | |||
| public IntPtr NativeXMLCallback; | |||
| } | |||
|
|
|||
| public static NativeCallbacks i_callbacks; | |||
|
|
|||
There was a problem hiding this comment.
Add:
public static NativeAPICallback APICallback = null;
etc for each of the 3.
Loader/Loader.cs
Outdated
| @@ -42,12 +44,14 @@ public static NativeCallbacks Load() | |||
| //PluginsContainer.LoadPluginsFromSubDirs(myLocation); | |||
|
|
|||
| // Return the marshalled callbacks for the native interfaces | |||
| return new NativeCallbacks | |||
| i_callbacks = new NativeCallbacks | |||
There was a problem hiding this comment.
Add:
APICallback = new NativeAPICallback(NativeAPIHandler);
etc for the 3
Loader/Loader.cs
Outdated
| @@ -42,12 +44,14 @@ public static NativeCallbacks Load() | |||
| //PluginsContainer.LoadPluginsFromSubDirs(myLocation); | |||
|
|
|||
| // Return the marshalled callbacks for the native interfaces | |||
| return new NativeCallbacks | |||
| i_callbacks = new NativeCallbacks | |||
| { | |||
| NativeAPICallback = Marshal.GetFunctionPointerForDelegate<NativeAPICallback>(NativeAPIHandler), | |||
There was a problem hiding this comment.
Change to:
NativeAPICallback = Marshal.GetFunctionPointerForDelegate(APICallback);
etc for the 3
No description provided.