Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smaller stuff like linting, remove old stuff, update dependencies #96

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix smaller stuff like linting, remove old stuff, update dependencies #96

merged 3 commits into from
Nov 24, 2023

Conversation

nicolasberens
Copy link
Contributor

A lot of small stuff:

  • fixed a lot of linting errors (ansible-lint --fix will also "fix" yaml formating)
  • updated dependencies and ansible version
  • reduced the ansible_managed string to not change on every run
  • removed collectd for our VMs
  • increased prometheus storage

Akira25
Akira25 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Akira25 Akira25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Akira25 Akira25 merged commit 4b1db22 into main Nov 24, 2023
8 checks passed
@Akira25
Copy link
Member

Akira25 commented Nov 24, 2023

Is this deployed or do we need to run it additionally?

@pktpls pktpls deleted the cleanup branch June 30, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akira25 Akira25 Akira25 approved these changes

@Noki Noki Awaiting requested review from Noki

@pmelange pmelange Awaiting requested review from pmelange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasberens @Akira25