Skip to content

Conversation

@sofkaski
Copy link

Returned translated placeholders to English.

Fixes the issue #1165.

Description

Placeholders were incorrectly also translated to Finnish which should not happen.

How has this been tested?

I installed the language file to my system and re-checked logs. No log writings any more.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

The Finnish translation file for the Spook component was updated to replace Finnish-specific placeholder tokens with language-neutral keys (e.g., {alueet}→{areas}, {nimike}→{title}, {lähde}→{source}) and to add a confirm_restart entry for restart_required flows.

Changes

Cohort / File(s) Summary
Finnish translation updates
custom_components/spook/translations/fi.json
Replace Finnish placeholder tokens with invariant English placeholders across automation and issue templates (examples: {alueet}{areas}, {laitteet}{devices}, {entiteetit}{entities}, {nimike}{title}, {apuri}{helper}, {kojelauta}{dashboard}, {tilanne}{scene}, {skripti}{script}, {lähde}{source}, {kerrokset}{floors}) and add a confirm_restart step under restart_required messages. Changes affect descriptions and titles for user_issue and automation_unknown_* entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

bugfix

Poem

🐰
I hopped through keys both small and tall,
Swapped Finnish hops for one-size-all,
Now templates sing in common tongue,
Restart prompt added — boing! we're done 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: correcting Finnish translation placeholders that were incorrectly translated instead of remaining in English.
Description check ✅ Passed The description clearly explains the issue, the fix applied, and testing performed; it directly relates to the changeset of correcting translated placeholders back to English.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sofkaski
Copy link
Author

I made this as a PR, but I suppose fixes should really come through WebLate. Right? I tried to use it, but it said that it is temporarily closed for maintenance.

Finnish language in the translation should be improved (a lot), but I did not touch to it here.

Returned translated placeholders to English.

Fixes the issue frenck#1165.
@sonarqubecloud
Copy link

@sofkaski
Copy link
Author

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant