Add Property Summary Data from MDN #49
Conversation
src/urls.ts
Outdated
| } | ||
| return ''; | ||
| } catch (ex) { | ||
| return '(Description not available)'; |
There was a problem hiding this comment.
Do we want this or should the string be empty and not generated into the JSDOC at all? Because properties that's missing compatibility data or the mdn_url will be ignored too.
A warning in the terminal would be suitable though (as for when the summaryElement is missing) to detect changes on their website since this solution is fairly fragile.
There was a problem hiding this comment.
If we leave it empty, it will try to reach out during each build. I guess that would make it easier to automatically fix these as they get fixed on mdn.
If you are cool with that, an empty string would work fine here. I'll a console warning as well.
There was a problem hiding this comment.
That's fine due to the fact that the link is wrong and should be fixed at MDN.
There was a problem hiding this comment.
Created an issue mdn/browser-compat-data#1998
src/urls.ts
Outdated
| console.log('fetching summary for ' + url); | ||
| urlData[url] = summaryData = scrapeSummary(url) || ''; | ||
| // todo: consider moving this to another part of the process | ||
| saveToFile(); |
|
|
|
I believe I have made all the changes we discussed. I ended up calling the summary |
PR for #48