Experimental support for Identifier Presence Scopes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfbd486 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
freshgum-bubbles
force-pushed
the
feat/identifier-presence-scope
branch
from
188176f
to
2df735e
Compare
It's currently not possible to check whether an identifier is part of a group, or whether it's a singular item. This means that, even if Container.has(A) = true, there is still a possibility that Container.get(A) will throw. This makes the API slightly confusing to deal with, as you have to know which keys form parts of a group, and which keys don't *before* using the API.
freshgum-bubbles
force-pushed
the
feat/identifier-presence-scope
branch
from
2df735e
to
dfbd486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Container.has(A)provides no guarantees thatContainer.get(A)will not throw. There is no way to check this, aside from checking internal maps
such as
metadataMapandmultiServiceIds.This presents an interesting problem: as
Container.get(A)may throw, even ifyou've checked for its presence, what do you do?
Container.get(A)call in atry { } catch { }... no.Number 3 is what we're going for.
Related Changes
@Service()error message patchXXX