feat: generalizing the command line #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frewsxcv This PR is ready for review. |
|
Also pinging @Manishearth, there's been a couple attempts at adding this (see #56, #48, and this), it would be nice to finally see this get added and a new release out. I'd love to be able to migrate our projects to cargo-nextest as well, but this is a blocker, and cargo-hack doesn't have nearly as good customization as this (see the Cargo.toml section), otherwise I'd use that. |
|
This is a big change, and I'm pretty busy these days. I agree that this would be a good feature to add. I'll perform a partial review but I really can't guarantee anything. |
Manishearth
reviewed
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides using
cargo-all-featureswith any other cargo subcommands and respect and pass arguments to them.The new command will look like this:
cargo all-features [subcommand] [subcommand args] [--] [args passed to subcommand with '--']Example:
Note: All three pre-defined commands (
cargo-[test,check,build]-all-features) have been removed and replaced with a new generic one. If you are willing to keep backward compatibility on this, please let me know to add them.