Use attributes #289
Open
Use attributes #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are changing to an attribute so it is easier to separate: - properties: things that are included in the datapackage.json list - attributes: things that the frictionless functions have added to pass objects from one function to the next Data frames do the same: `attributes(iris)` We still remove all attributes in write_package (write_resource), so that the invisibly returned package is as written to disk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 650 658 +8
=========================================
+ Hits 650 658 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why attributes
We are changing to an attributes so it is easier to separate:
Data frames do the same:
attributes(iris)We still remove all attributes in write_package (write_resource), so that the invisibly returned package is as written to disk
Affected properties
package$directorytoattr(package, "directory")resource$read_fromtoattr(resource, "data_location")