Optimize logging and fix connection information in Consumer (#709)

* Optimize logging and fix connection information in Consumer * Optimize logging and handle connection loss in Consumer.php --------- Co-authored-by: Deeka Wong <[email protected]>
friendsofhyperf · Sep 5, 2024 · 406f903 · 406f903
1 parent 767bd0a
commit 406f903
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Consumer.php b/src/Consumer.php
@@ -91,19 +91,20 @@ public function start(): void
             Coroutine::create(function () use ($context) {
                 CoordinatorManager::until(Constants::WORKER_EXIT)->yield();
                 $this->stop();
-                $this->logger?->warning('[{connection}] Consumer stopped.', $context);
+                $this->logger?->warning('[{connection}] Consumer exit.', $context);
             });
 
             while (1) {
                 if ($this->isStopped()) {
+                    $this->logger?->warning('[{connection}] Consumer stopped.', $context);
                     break;
                 }
 
                 try {
                     $replication->consume();
                 } catch (SocketException $e) {
-                    // todo: reconnect
-                    $this->logger?->debug('[{connection}] Connection lost, reconnected.', $context);
+                    $this->stop();
+                    $this->logger?->warning('[{connection}] Connection lost, will retry later.', $context);
                 }
             }
         };

diff --git a/src/Monitor/HealthMonitor.php b/src/Monitor/HealthMonitor.php
@@ -24,7 +24,7 @@
 
 class HealthMonitor
 {
-    protected BinLogCurrent $binLogCurrent;
+    protected ?BinLogCurrent $binLogCurrent = null;
 
     protected int $monitorInterval = 10;