-
Notifications
You must be signed in to change notification settings - Fork 244
Custom Target Expressions #2184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
validateCustomExpression
Custom Functions prerelease 2 parseCustomExpression
Custom Functions, Finally
functional stats did not work
init tab
getTeamData(override)
getTeamData(override)
format
fix test & typecheck & format
|
I don't know why, but since this PR was published I have never encountered the optimizer refusing to work when I used CTE. |
Minimum (un)viable option. Slowly, very slowly...
Better, but still terribly slow...
Fix typecheck
Fix format
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When converting, an empty expression appeared.
Describe your changes
I added support for custom target expressions and a convenient editor.

Since the last PR I have found at least one indisputably correct way to use CTE.
Example: https://discord.com/channels/785153694478893126/1035719815622561892/1244630283052126298
Another example: https://discord.com/channels/785153694478893126/1035720633167921313/1237378233666633850
Testing/validation
The optimizer sometimes refuses to work with some large expressions. Like this:

This can be bypassed by slightly changing the form of the expression without changing the essence.

Also, this case is calculated incorrectly. Although when it is used as part of a larger expression, it is calculated as expected.

I can't fix it. It's an engine issue. I preferred to forget about it until the transition to Pando.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.