Skip to content

Conversation

@priolette
Copy link
Collaborator

Describe your changes

Instead of using one big meta.ts file, now every character, disc, wengine and common sheets have separate folders with buffs.ts, conditionals.ts and formulas.ts files.

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@priolette priolette requested a review from nguyentvan7 October 16, 2025 18:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

105 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch priolette/meta-split

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025

[zzz-frontend] [Sat Oct 18 10:02:42 UTC 2025] - Deployed d92b3a6 to https://genshin-optimizer-prs.github.io/pr/3086/zzz-frontend (Takes 3-5 minutes after this completes to be available)

[zzz-frontend] [Tue Oct 21 16:50:56 UTC 2025] - Deployed ee69a47 to https://genshin-optimizer-prs.github.io/pr/3086/zzz-frontend (Takes 3-5 minutes after this completes to be available)

[Tue Oct 21 17:55:11 UTC 2025] - Deleted deployment

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One addl comment

'assistSkill',
] as const

export const commonSheets = ['enemy', 'anomaly'] as const
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment for what should be in commonSheets vs just going directly into sheets arr

@priolette priolette merged commit e8f196d into master Oct 21, 2025
15 of 17 checks passed
@priolette priolette deleted the priolette/meta-split branch October 21, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants