-
Notifications
You must be signed in to change notification settings - Fork 244
ZO: Change meta file generation to be split up #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 105 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[zzz-frontend] [Sat Oct 18 10:02:42 UTC 2025] - Deployed d92b3a6 to https://genshin-optimizer-prs.github.io/pr/3086/zzz-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Tue Oct 21 16:50:56 UTC 2025] - Deployed ee69a47 to https://genshin-optimizer-prs.github.io/pr/3086/zzz-frontend (Takes 3-5 minutes after this completes to be available) [Tue Oct 21 17:55:11 UTC 2025] - Deleted deployment |
nguyentvan7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One addl comment
| 'assistSkill', | ||
| ] as const | ||
|
|
||
| export const commonSheets = ['enemy', 'anomaly'] as const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment for what should be in commonSheets vs just going directly into sheets arr
Describe your changes
Instead of using one big
meta.tsfile, now every character, disc, wengine and common sheets have separate folders withbuffs.ts,conditionals.tsandformulas.tsfiles.Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.