-
Notifications
You must be signed in to change notification settings - Fork 244
Add Luna II Content #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Luna II Content #3092
Conversation
WalkthroughThis pull request adds a new character (Nefer) and three new weapons (SacrificersStaff, DawningFrost, ReliquaryOfTruth) to the Genshin Optimizer codebase by extending existing character and weapon key arrays with corresponding asset references and type definitions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (293)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[frontend] [Wed Oct 22 03:39:17 UTC 2025] - Deployed 0e5541a to https://genshin-optimizer-prs.github.io/pr/3092/frontend (Takes 3-5 minutes after this completes to be available) [Wed Oct 22 17:57:49 UTC 2025] - Deleted deployment |
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit