suggestion for issue template #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with other meta issues related to processing RFCs
abelbraaksma
approved these changes
May 5, 2024
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
nojaf
suggested changes
May 6, 2024
| about: Discuss editor / tooling formatting concerns and code style guidelines | ||
| title: '' | ||
| labels: [style-guide, under-discussion] | ||
| assignees: '@nojaf,@KathleenDollard,@dsyme' |
There was a problem hiding this comment.
Keep my name out of this, please.
| * [ ] If this is code formatter discussion, please suggest a detailed list of settings names and their default values, with their behaviour | ||
| * [ ] the choice for tooling support should be based on ease of implementation in code formatter | ||
| * [ ] the choice for tooling output should be based on | ||
| * [ ] conserving original formatting but for specific predicate that makes code significantly less maintainable |
There was a problem hiding this comment.
Sigh, this is again a very on the nose commentary of Gauthier.
Fantomas today does not preserve any of the existing code style. This won't change and I don't want this is in an issue template that suggests otherwise.
| * [ ] There are examples of codeformatters settings in other languages / tooling available (add items nested under this list with one link per line), add screenshots to the description | ||
| * [ ] There are examples of codeformatters implementation available (add items nested under this list with one link per line) | ||
|
|
||
| [^1] this is generally evaluated by the person implementing and the entity potentially sponsoring the work |
There was a problem hiding this comment.
Once more, we Fantomas maintainers strongly object to additional settings! Merely proposing a PR doesn't grant you authority here. Modifying settings in Fantomas should only be considered as a final option, subject to approval by the maintainers.
…ue.md Co-authored-by: Abel Braaksma <[email protected]>
…ue.md Co-authored-by: Abel Braaksma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to split code formatting / style guide with other meta issues related to processing RFCs or non specific issues.
Mostly based on reflection that came after engaging about formatting and style guide community process.
Probably needs more efforts and consensus, but maybe it is good enough new default rather than what we have currently?
cc: @vzarytovskii, @nojaf, @dsyme, @KathleenDollard