-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion for issue template #757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with other meta issues related to processing RFCs
abelbraaksma
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Let's get this in. Just a few nits, but I don't really have a strong opinion about the text r.n.
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
nojaf
suggested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reservations.
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
…ue.md Co-authored-by: Abel Braaksma <[email protected]>
…ue.md Co-authored-by: Abel Braaksma <[email protected]>
T-Gro
reviewed
Feb 12, 2025
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Feb 12, 2025
.github/ISSUE_TEMPLATE/code_formatting_guidelines_specific_issue.md
Outdated
Show resolved
Hide resolved
…ue.md Co-authored-by: Tomas Grosup <[email protected]>
…ue.md Co-authored-by: Tomas Grosup <[email protected]>
T-Gro
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to split code formatting / style guide with other meta issues related to processing RFCs or non specific issues.
Mostly based on reflection that came after engaging about formatting and style guide community process.
Probably needs more efforts and consensus, but maybe it is good enough new default rather than what we have currently?
cc: @vzarytovskii, @nojaf, @dsyme, @KathleenDollard