Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special functions tests #207

Merged
merged 11 commits into from
Jun 27, 2022
Merged

Add special functions tests #207

merged 11 commits into from
Jun 27, 2022

Conversation

kMutagene
Copy link
Member

@kMutagene kMutagene commented Jun 22, 2022

This PR will add tests for the following special functions:

  • Binomial
  • Erf
  • Factorial
  • Logistics
  • Gamma
  • Beta

implements #215 for erfcx, gamma, gammaLn, beta, betaLn, factorial, factorialLn,Binomial.coefficient, Binomial.coefficientLn

@kMutagene kMutagene marked this pull request as draft June 22, 2022 14:17
@kMutagene kMutagene changed the title Add factorial and factorialLn tests Add special functions tests Jun 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #207 (8582dd7) into developer (262f1ac) will increase coverage by 0.57%.
The diff coverage is 96.22%.

@@              Coverage Diff              @@
##           developer     #207      +/-   ##
=============================================
+ Coverage      31.61%   32.19%   +0.57%     
=============================================
  Files            124      124              
  Lines          11664    11707      +43     
  Branches        1784     1786       +2     
=============================================
+ Hits            3688     3769      +81     
+ Misses          7535     7494      -41     
- Partials         441      444       +3     
Impacted Files Coverage Δ
src/FSharp.Stats/SpecialFunctions/Logistic.fs 100.00% <ø> (+100.00%) ⬆️
tests/FSharp.Stats.Tests/Main.fs 0.00% <0.00%> (ø)
src/FSharp.Stats/SpecialFunctions/Erf.fs 96.42% <75.00%> (+57.96%) ⬆️
src/FSharp.Stats/SpecialFunctions/Factorial.fs 88.88% <100.00%> (+88.88%) ⬆️
tests/FSharp.Stats.Tests/SpecialFunctions.fs 100.00% <100.00%> (ø)
src/FSharp.Stats/Fitting/Spline.fs 91.17% <0.00%> (-0.26%) ⬇️
src/FSharp.Stats/Array.fs 0.00% <0.00%> (ø)
...tats/ML/Unsupervised/PrincipalComponentAnalysis.fs 0.00% <0.00%> (ø)
src/FSharp.Stats/Ops.fs 4.00% <0.00%> (+0.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262f1ac...8582dd7. Read the comment docs.

@kMutagene kMutagene marked this pull request as ready for review June 23, 2022 13:19
@kMutagene
Copy link
Member Author

kMutagene commented Jun 24, 2022

@bvenn as this now also changes code usage of special functions in the distribution modules, i'd suggest to merge this first and rebase all other PRs from the hackathon that fix code on this. Double check for correct usage of e.g. _gamma instead of gamma in new commits.

@bvenn bvenn merged commit 5837ae8 into developer Jun 27, 2022
@bvenn bvenn deleted the special-functions-test branch June 27, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants