Add GenerateReleaseNotes support to GitHub #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymens
force-pushed
the
expand-github-support-generate-releasenotes
branch
from
7bfa94d
to
302669d
Compare
xperiandri
force-pushed
the
expand-github-support-generate-releasenotes
branch
from
302669d
to
a9b525b
Compare
xperiandri
approved these changes
Oct 1, 2023
|
Approved, thank you very much for the contribution! |
xperiandri
force-pushed
the
expand-github-support-generate-releasenotes
branch
from
a9b525b
to
173d96f
Compare
|
@raymens can you rebase? Or invite to your repo, I'll rebase myself |
raymens
force-pushed
the
expand-github-support-generate-releasenotes
branch
from
df56cb8
to
00762a4
Compare
|
@xperiandri I've rebased the solution |
xperiandri
force-pushed
the
expand-github-support-generate-releasenotes
branch
from
00762a4
to
40fe48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option for the GitHub Create Release step to enable generating of release notes.
Had to update the Octokit package for it.
I noticed some differences between the (new?) GitHub API and how the package is structured in FAKE.
For example that currently the name of the release always equals the tagname for FAKE while these are different in GitHub.
However I didn't want to necessarily take that on in this PR.
I did not find any docs or tests I would need to update.
TODO
Feel free to open the PR and ask for help