Update assembly-resolver to not hardcode .NET 6.0 #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperiandri
force-pushed
the
sdk-assembly-resolver-update
branch
from
17acb92
to
efe34c8
Compare
|
@Thorium formatting required |
|
Thanks, done... |
xperiandri
reviewed
Jul 11, 2024
yes, and probably to the error message! Edit: Added to error message. But there is no documentation for the other environment variables either. |
|
And update release notes, please |
This was referenced Jul 11, 2024
xperiandri
force-pushed
the
sdk-assembly-resolver-update
branch
from
ef83e75
to
3ea4ae2
Compare
xperiandri
requested changes
Jul 14, 2024
Co-authored-by: Andrii Chebukin <[email protected]>
|
This should be good now. |
xperiandri
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some workarounds to issue [mentioned in https://github.com//issues/2713]:(#2713 (comment))
The .NET version was for no reason hard-coded to 6.0 and not coming from an environment variable that can be overwritten by the user. There is no reason why Fake needs to be updated every time .NET version updates.
This commit adds new
FAKE_SDK_RESOLVER_CUSTOM_DOTNET_VERSIONwhich can be used to change the default "6.0" to whatever other version. So you set it to .NET "18.5" if you want.Also, this changes assembly-resolver to use lists instead of single strings:
SdkVersionRawsSdkVersionsandPaketFrameworkIdentifiers. The default is still list of single item ["6.0"] to not break any backward-compatibility. However, in many cases the user has multiple NET versions installed in the computer and is just interested of whatever defined in wherever "globals.json" and not what Fake is compiled with. Currently the system just throws build errors, meanwhile user would just want to old VB style on-error-resume-next: "come on, build it now!", e.g. user tries to builds .NET 8 software. So you can define "6.0" and "8.0" and then the assembly-resolver will check what it can find. There are still backward compatible versions kept,SdkVersionRawSdkVersionandPaketFrameworkIdentifierwhich just take the first from the list.