Skip to content

Modify task extensions to support backgroundTask #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify task extensions to support backgroundTask #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/FSharp.Control.TaskSeq/TaskExtensions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ open Microsoft.FSharp.Core.LanguagePrimitives.IntrinsicOperators
[<AutoOpen>]
module TaskExtensions =

// Add asynchronous for loop to the 'task' computation builder
type Microsoft.FSharp.Control.TaskBuilder with
// Add asynchronous for loop to the 'task' and 'backgroundTask' computation builders
type TaskBuilderBase with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that shows the use of TaskBuilderBaseBuilder.


/// Used by `For`. F# currently doesn't support `while!`, so this cannot be called directly from the task CE
/// This code is mostly a copy of TaskSeq.WhileAsync.
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Control.TaskSeq/TaskExtensions.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace FSharp.Control
[<AutoOpen>]
module TaskExtensions =

type TaskBuilder with
type TaskBuilderBase with

/// <summary>
/// Inside <see cref="task" />, iterate over all values of a <see cref="taskSeq" />.
Expand Down
Loading