Skip to content

Convert fake build script into a build project #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2025

Conversation

bisen2
Copy link
Contributor

@bisen2 bisen2 commented Mar 5, 2025

This PR converts the existing build.fsx script into a full build project at build/build.fsproj. This lets folks who don't have the .NET 6 runtime assemblies build the project (see fsprojects/FAKE#2719 for info on why fake runner requires net6 still).

There are a ton of automatically changed files in this PR due to fantomas and fake liking to fiddle with all of the source files, so I tried to split the automated changes that aren't really specific to this PR into the first two commits (62781d5 and f9bacd2) and the actually relevant changes in the remaining three (8b06a7a, 43859cd, and 62cd386). Essentially, any changes not in /, /build, or /.github were made by fantomas and fake.

@dsyme
Copy link
Contributor

dsyme commented Mar 11, 2025

@bisen2 Thank you for this! However it has unfortunately conflicted badly with the PR from @EverybodyKurts . Could you take a loko and redo or revise as you see fit? Many thanks!

@EverybodyKurts
Copy link
Collaborator

Hi @bisen2, I took the liberty of fixing the merge conflicts in your pull request, along with bumping the assembly version to 6.6.0.

@bisen2
Copy link
Contributor Author

bisen2 commented Mar 13, 2025

Thanks, @EverybodyKurts!

Copy link
Collaborator

@EverybodyKurts EverybodyKurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR converts the existing build.fsx script into a full build project at build/build.fsproj. It removes the fake cli tool as well as drops support for net6, since it has reached end of life.

@EverybodyKurts EverybodyKurts merged commit 57c5251 into fsprojects:main Mar 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants