Skip to content

Avoid ReadToEnd and use XDocument taking reader instead #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid ReadToEnd and use XDocument taking reader instead #1527

wants to merge 1 commit into from

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Mar 25, 2025

Avoid ReadToEnd and use XDocument taking reader instead.

Possible fix for #1501

@Thorium
Copy link
Member Author

Thorium commented Mar 25, 2025

Ubuntu CI failed for "CsvRuntime.fs needs formatting". However, this PR only touches XmlRuntime.fs not CsvRuntime.fs.
Locally running Fantomas or dotnet run --project build/build.fsproj -- -t Format is not changing any files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Thorium