Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit dependency on FSharp.Core #177

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Feb 3, 2024

fixes #176

@dawedawe dawedawe requested a review from SchlenkR February 3, 2024 23:36
@SchlenkR
Copy link
Member

SchlenkR commented Feb 5, 2024

Just to clarify: Will this change (having FsHttp reference F# Core 8) be working for FsHttp users targeting combinations of dotnet SDK / F# with versions lower than 8?

@dawedawe
Copy link
Member Author

dawedawe commented Feb 5, 2024

Just to clarify: Will this change (having FsHttp reference F# Core 8) be working for FsHttp users targeting combinations of dotnet SDK / F# with versions lower than 8?

The combinations should still work as before.
I checked with a project having TargetFramework = net6.0 and a local nuget source.
We are already doing this for FsHttp.FSharpData.
The explicit dependencies of FsHttp.FSharpData can also be seen here
The FsHttp package shows the missing explicit dependency here, that should be fixed with 14.4.1.

@SchlenkR
Copy link
Member

SchlenkR commented Feb 5, 2024

Thank you so much for taking your time @dawedawe for trying out and sharing, and the PR. Great stuff!

@SchlenkR SchlenkR merged commit ce5858e into fsprojects:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FsHttp Has an Implicit Dependency on Fsharp.Core 8.0+ from version 12.0.0 on
2 participants