Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Hash Directive more strictly inside of lists or arrays #3080

Conversation

Linschlager
Copy link
Contributor

Resolves #3079

Instead of giving up on Stroustrup-Formatting whenever there is Trivia on the closing brackets, only do that for HashDirectives and allow any other kind of Trivia such as comments or NewLines

@Linschlager Linschlager changed the title Check Hash Directive more carefully inside of lists or arrays Check Hash Directive more strictly inside of lists or arrays Apr 15, 2024
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.
Do you want a release for this?

@Linschlager
Copy link
Contributor Author

Linschlager commented Apr 16, 2024

Thanks, this looks good. Do you want a release for this?

That would be awesome as it's currently blocking us from updating to the latest version

@nojaf nojaf enabled auto-merge (squash) April 16, 2024 07:04
@nojaf nojaf merged commit 873d9d7 into fsprojects:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: An empty line or comment at the end of a list breaks Stroustrup formatting
2 participants