Skip to content

Add active pattern for empty computation expression#3141

Merged
nojaf merged 3 commits intofsprojects:v7.0from
nojaf:edgar-empty-ce
Dec 12, 2024
Merged

Add active pattern for empty computation expression#3141
nojaf merged 3 commits intofsprojects:v7.0from
nojaf:edgar-empty-ce

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Dec 10, 2024

Fixes #3140

I took a bit of a shortcut, that is why there is an additional space after formatting.
This might be ok to for now.

@nojaf
Copy link
Contributor Author

nojaf commented Dec 10, 2024

The generated lex.fsi no longer seems valid.
module Ranges =/// Rule token is invalid according to the latest SDK.
I'm not sure why this generating to no longer working.

@Martin521 does this ring a bell? Did anything change in that area?

@Martin521
Copy link
Contributor

No, I am not aware of changes.
What exactly do you mean by your comment? Does compilation of the generated lex.fs create errors? And the error message is module Ranges =/// Rule token?
module Ranges and //Rule token are in quite different places in lex.fs.

@nojaf
Copy link
Contributor Author

nojaf commented Dec 10, 2024

Yes, the generated lex.fs contains invalid code and compilation fails.
I can't quite piece together why this is happening now.
Maybe you have seen this before, since you did some work in that area.

@nojaf nojaf merged commit 5d7a379 into fsprojects:v7.0 Dec 12, 2024
nojaf added a commit that referenced this pull request Jan 10, 2025
* Add active pattern for empty computation expression

* Comment out lex.fsi

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments