Verify Content-Encoding when querying Content-Length #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
reviewed
Aug 5, 2023
| # Some servers may choose to ignore Accept-Encoding and return | ||
| # compressed content, in which case the returned size is unreliable. | ||
| if r.headers.get("Content-Encoding", "identity") == "identity": | ||
| info["size"] = int(r.headers["Content-Length"]) |
There was a problem hiding this comment.
Otherwise is remains None and can only be streamed? That is probably right, but could use some tests to make sure we are getting the right behaviour.
nkemnitz
force-pushed
the
http-truncate-fix
branch
from
b204fa7
to
e812fa9
Compare
|
Added a test that will fail on the current main branch and succeed with this PR. |
martindurant
reviewed
Aug 9, 2023
| ) | ||
| url = server + "/index/realfile" | ||
|
|
||
| with h.open(url, "rb") as f: |
There was a problem hiding this comment.
f is a streaming type file here, with None for the size? Should probably assert that.
There was a problem hiding this comment.
Ah, not super familiar with fsspec, yet - Only tried to mimic the test above this one. Added assertions for type and size, now.
nkemnitz
force-pushed
the
http-truncate-fix
branch
from
e812fa9
to
6f4da09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1319.