Handle cache_timeout = 0 in GCSFileSystem (#646)

* add is not none * test
fsspec · Nov 4, 2024 · 7b9ef9c · 7b9ef9c
1 parent 358ba23
commit 7b9ef9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/gcsfs/core.py b/gcsfs/core.py
@@ -285,7 +285,7 @@ def __init__(
         version_aware=False,
         **kwargs,
     ):
-        if cache_timeout:
+        if cache_timeout is not None:
             kwargs["listings_expiry_time"] = cache_timeout
         super().__init__(
             self,

diff --git a/gcsfs/tests/test_core.py b/gcsfs/tests/test_core.py
@@ -1428,6 +1428,8 @@ def test_expiry_keyword():
     assert gcs.dircache.listings_expiry_time == 1
     gcs = GCSFileSystem(cache_timeout=1, token="anon")
     assert gcs.dircache.listings_expiry_time == 1
+    gcs = GCSFileSystem(cache_timeout=0, token="anon")
+    assert gcs.dircache.listings_expiry_time == 0
 
 
 def test_copy_cache_invalidated(gcs):