Fix for slower exists() and info() calls #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an optimization to the `info()` method to reduce the number of GCS API calls when inspecting a directory-like path that only contains subdirectories without any immediate objects. Also includes a test case to check the number of API calls for this edge case
This commit introduces an optimization to the `info()` method to reduce the number of GCS API calls when inspecting a directory-like path that only contains subdirectories without any immediate objects. Also includes a test case to check the number of API calls for this edge case
Member
|
Looks good, thank you! |
Member
|
(sorry, I can't push to protected "main" to fix your linting). |
APatrickJ
approved these changes
Oct 29, 2025
APatrickJ
left a comment
APatrickJ
left a comment
There was a problem hiding this comment.
Tested (see #704 (comment)) and confirmed this fixed our performance issue
Member
|
Thank you @Mahalaxmibejugam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the slower exists() and info() calls on the latest version, detailed explanation in #704 (comment)