chore: refactor tests #29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the test suite incredibly easy to add to with more tests, and more "file systems" we can initialize through opendal. This is done in a few ways:
Note that tests here are going to fail until the core of the abstraction inherits from
AbstractFileSystemand implements the required methods.I do not expect this to be merged until the underlying functionality is implemented, but we need to think about how to correctly initialize an fs from a given URI before implementing.
An open question I have is why keep this repository separate? Why not just include this out of the box upstream in the OpenDAL repo?