Skip to content

Conversation

@jayceslesar
Copy link

This makes the test suite incredibly easy to add to with more tests, and more "file systems" we can initialize through opendal. This is done in a few ways:

  1. Using make to set up the integration tests instead of manually running detached docker compose
  2. Render each file system (only one currently) as its own fixture
  3. Combine the fixtures into an iterator that we can parameterize across any test(s).

Note that tests here are going to fail until the core of the abstraction inherits from AbstractFileSystem and implements the required methods.

I do not expect this to be merged until the underlying functionality is implemented, but we need to think about how to correctly initialize an fs from a given URI before implementing.

An open question I have is why keep this repository separate? Why not just include this out of the box upstream in the OpenDAL repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants