Skip to content

tui timezone #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

tui timezone #1514

merged 2 commits into from
Apr 18, 2025

Conversation

fujiapple852
Copy link
Owner

Closes #1513

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces timezone configuration for the TUI by adding a new configuration field, CLI argument, and runtime logic for timezone conversion. It updates documentation, configuration structs, parsing logic, tests, and dependencies to support timezone customization.

  • Added documentation and sample configuration for the TUI timezone in trippy-config-sample.toml.
  • Extended TUI configuration structures and command line parsing to include an optional timezone setting.
  • Updated header rendering to conditionally display the current time in the configured timezone and added related tests.

Reviewed Changes

Copilot reviewed 10 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
trippy-config-sample.toml Added comments for the timezone configuration
crates/trippy-tui/src/frontend/render/header.rs Updated rendering logic to handle an optional timezone
crates/trippy-tui/src/frontend/config.rs Added a timezone field to TuiConfig
crates/trippy-tui/src/config/file.rs Introduced the tui_timezone field in the file configuration
crates/trippy-tui/src/config/cmd.rs Added a command line argument for setting timezone
crates/trippy-tui/src/config.rs Parsed the timezone configuration and integrated tests for it
crates/trippy-tui/src/app.rs Passed the timezone configuration in the TUI config construction
crates/trippy-tui/Cargo.toml & Cargo.toml Added and updated the dependency on chrono-tz
Files not reviewed (10)

@fujiapple852 fujiapple852 enabled auto-merge (rebase) April 18, 2025 10:47
@fujiapple852 fujiapple852 merged commit e1d4c2b into master Apr 18, 2025
22 checks passed
@fujiapple852 fujiapple852 deleted the feat-tui-timezone branch April 18, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TUI clock timezone configuration
1 participant