Skip to content

Allow fgbio tools to access meta information about themselves. #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

Allow fgbio tools to access meta information about themselves. #427

merged 4 commits into from
Jul 9, 2025

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 20, 2018

This allows SAM program records to be created.

@nh13 nh13 requested a review from tfenne August 20, 2018 16:49
nh13
nh13 commented Aug 20, 2018
View reviewed changes
@codecov-io
Copy link

codecov-io commented Aug 20, 2018 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (3d95e2c) to head (01f878e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   95.66%   95.68%   +0.02%     
==========================================
  Files         129      129              
  Lines        7636     7654      +18     
  Branches      528      507      -21     
==========================================
+ Hits         7305     7324      +19     
+ Misses        331      330       -1
Flag Coverage Δ
unittests 95.68% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tfenne
tfenne reviewed Aug 29, 2018
View reviewed changes
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I really like this. A bunch of minor suggestions for you.

@tfenne tfenne assigned nh13 and unassigned tfenne Aug 29, 2018
@nh13 nh13 mentioned this pull request Nov 3, 2018
Closed
@nh13 nh13 force-pushed the nh_tool_meta branch 2 times, most recently from 1476f09 to 14fcaeb Compare November 3, 2018 21:54
@nh13
Copy link
Member Author

nh13 commented Nov 3, 2018 •
edited
Loading

@tfenne this PR got a bit bigger in scope: I added support for collections in Metric classes. It will join values via the comma separator by default, though I don't love the way I have allowed the "collection delimiter" to be exposed (should I even do that now?).

Moved this to #1042

@nh13 nh13 assigned tfenne and unassigned nh13 Nov 6, 2018
@nh13 nh13 assigned nh13 and unassigned tfenne Mar 5, 2025
@nh13 nh13 changed the base branch from main to feat/metric-supports-collections March 13, 2025 01:00
@nh13 nh13 assigned clintval and unassigned nh13 Mar 13, 2025
@nh13 nh13 requested a review from clintval March 13, 2025 01:02
clintval
clintval reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@clintval clintval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions and recommended some fixups too.

Let me know when you are ready for a re-review. It's close!

@clintval clintval assigned nh13 and unassigned clintval Mar 24, 2025
@nh13 nh13 force-pushed the feat/metric-supports-collections branch 2 times, most recently from 58928ba to 4d369ca Compare April 18, 2025 19:11
@nh13 nh13 force-pushed the feat/metric-supports-collections branch 2 times, most recently from 7ba0840 to 2aa7a41 Compare April 18, 2025 19:43
Base automatically changed from feat/metric-supports-collections to main April 18, 2025 19:54
@nh13
Allow fgbio tools to access meta information about themselves.
7910ce6 
This allows SAM program records to be created.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://fulcrumgenomics.github.io/fgbio/pr-preview/pr-427/

Built to branch gh-pages at 2025-07-09 04:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@nh13 nh13 requested a review from clintval July 9, 2025 04:16
@nh13 nh13 merged commit a3e2ab5 into main Jul 9, 2025
16 checks passed
@nh13 nh13 deleted the nh_tool_meta branch July 9, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfenne tfenne tfenne left review comments

@clintval clintval clintval approved these changes

Assignees

@nh13 nh13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nh13 @codecov-io @tfenne @clintval