Validate DelimFile headers #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theJasonFan
commented
Apr 24, 2024
| @@ -24,6 +24,7 @@ flate2 = "^1" | |||
| # For auto-serialization of structs to csv/tsv | |||
| csv = "^1" | |||
| serde = { version = "^1.0.123", features = ["derive"] } | |||
| serde-aux = "^4" | |||
There was a problem hiding this comment.
Used for serde / field name introspection. fqtk uses the same crate.
theJasonFan
commented
Apr 24, 2024
| @@ -171,8 +171,16 @@ impl<D: DeserializeOwned> DelimFileReader<D> { | |||
| .has_headers(true) | |||
| .quoting(quote) | |||
| .from_reader(reader); | |||
| assert!(csv_reader.has_headers(), "Expected input file to have a header row"); | |||
There was a problem hiding this comment.
I removed this assert. It wasn't actually checking for a header line but instead just checks that the reader is configured to read a header.
theJasonFan
commented
Apr 24, 2024
| let header = csv_reader.headers().map_err(FgError::ConversionError)?.to_owned(); | ||
| if !header.is_empty() { |
There was a problem hiding this comment.
Empty files return empty headers, so we validate headers for only non-empty TSVs.
theJasonFan
requested review from
nh13,
jdidion,
ameynert and
tfenne
and removed request for
nh13
theJasonFan
commented
Apr 24, 2024
jdidion
approved these changes
Apr 24, 2024
If this is still the case, could you add a test for it? |
theJasonFan
commented
Apr 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to parse DelimFile headers.